Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: Catchable fatal error #6121

Closed
jeherve opened this issue Jan 18, 2017 · 3 comments · Fixed by #6122
Closed

Sharing: Catchable fatal error #6121

jeherve opened this issue Jan 18, 2017 · 3 comments · Fixed by #6122
Assignees
@jeherve
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Sharing Post sharing, sharing buttons [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Jan 18, 2017 •
edited

In some specific configurations, one gets the following error when the Sharing module is active:

Catchable fatal error: Argument 2 passed to Share_Facebook::__construct() must be of the type array, null given, called in wp-content/plugins/jetpack/modules/sharedaddy/sharing-service.php on line 207 and defined in wp-content/plugins/jetpack/modules/sharedaddy/sharing-sources.php on line 871

Digging into this right now to find out more.

Reported here:
@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons [Pri] High [Status] In Progress [Type] Bug When a feature is broken and / or not performing as intended labels Jan 18, 2017
@jeherve jeherve added this to the 4.5.1 milestone Jan 18, 2017
@jeherve jeherve self-assigned this Jan 18, 2017
@StefMattana
Copy link

Another one here:

  • 3004448-t

jeherve added a commit that referenced this issue Jan 18, 2017
@jeherve
Sharing: force get sharing options when saved options are incorrect
415c3b1 
Fixes #6121
@jeherve jeherve mentioned this issue Jan 18, 2017
Merged
@lamdayap
Copy link

Also reported here: 3010291-t

@jeherve jeherve modified the milestones: 4.5.1, 2/17 - February Jan 30, 2017
@jenhooks
Copy link

Here, too: 3099833-t

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Sharing Post sharing, sharing buttons [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sharing: force get sharing options when saved options are incorrect Automattic/jetpack
6 participants
@kraftbj @jeherve @jenhooks @StefMattana @lamdayap @matticbot