Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an isset check to avoid PHP notice #10261

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Add an isset check to avoid PHP notice #10261

merged 1 commit into from
Oct 8, 2018

Conversation

bor0
Copy link
Member

@bor0 bor0 commented Oct 5, 2018

Fixes #10071

Changes proposed in this Pull Request:

  • Add an isset check to avoid PHP notice

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D19150-code. (newly created revision)

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️

"Testing instructions" are missing for this PR. Please add some
⚠️

"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@bor0 bor0 added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Oct 5, 2018
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] WPCOM API [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 5, 2018
jeherve
jeherve approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work well. Thanks for your contribution!

@kraftbj kraftbj added this to the 6.7 milestone Oct 8, 2018
@kraftbj kraftbj merged commit 0f551e1 into master Oct 8, 2018
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 8, 2018
@kraftbj kraftbj deleted the fix/issue-10071 branch October 8, 2018 15:17
@kraftbj
Copy link
Contributor

kraftbj commented Oct 17, 2018

Synced to wp.com via r182079-wpcom

jeherve added a commit that referenced this pull request Oct 26, 2018
@jeherve
Changelog: add #10261
1f4ceed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Feature] WPCOM API Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bor0 @matticbot @jetpackbot @kraftbj @jeherve