-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mailchimp gutenberg block #10619
Mailchimp gutenberg block #10619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! ❤️
How do you feel about moving the client side of the block to Calypso, and have it be built by the SDK and shipped as part of the Jetpack preset, under the Jetpack category?
I'm happy to provide you with some details and all the support you'll need if that sounds good to you.
@tyxla how exactly would that work? Move the javascript itself to Calypso? I am confused a bit, since I have exatly 6 hours of Gutenberg experience now so please pardon my naive questions :) |
Yes :) That is how we've been working on many other blocks for Jetpack. Then, we use the SDK for building the blocks (you can read more about it here).
Good question - we release the blocks from Calypso as a separate npm package, and have a process to include and use that package in Jetpack. You can read more about it in pafL3P-4t-p2. Finally, if you need some examples, you can have a look at the blocks we already have in Calypso, for example Markdown. Let me know if you have any questions! |
251fece
to
716306c
Compare
This turns shortcode introduced in #10597 into a server-rendered gutenberg block.
The JS part of the process is in Automattic/wp-calypso#28798
Testing instructions
npm run sdk gutenberg client/gutenberg/extensions/presets/jetpack -- --output-dir=~/GIT/jetpack/_inc/blocks -w
to your proper Jetpack diremail-subscribe
block, use it, publish and see on the frontendIf you want the block to actually work (collect email):
(this is the same flow as in #10597)
You need to be an a12n to connect Mailchimp.