-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ESLint to 5.12.0 #11095
Upgrade ESLint to 5.12.0 #11095
Conversation
This is an automated check which relies on |
OK all these PRs seems to do the same thing. That's a good sign 😄 What are the next steps (cc @brbrr). Can I help with something? |
I'll be happy to take it over :) |
I went through all the ESLint errors and tried to fix all of them. Unfortunately, some of the errors are trickier than other errors, so I disabled some rules with the intention to tackle these errors later with a more incremental approach: #11142 Most rule fixes are grouped by commits for ease of review (you might not want to review the all the changes at once) |
85bd569
to
f5a57eb
Compare
f5a57eb
to
0719109
Compare
@brbrr I took a look and everything made sense to me. Would you be game for a rebase and we can get it across the line ASAP after the rebase. |
Rebased! Let's push it through :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense to me. Built fine and the dashboard works as expected with changing settings, etc.
ESLint upgrade to latest version. Needed mainly to move Babel upgrade in #10810 forward. Old ESLint uses old version of the
babel-eslint
package that's not compatible with Babel 7.There is plenty of new ESLint errors reported now, as the rules got upgraded:
connect
-- leads to unnecessary rerendersI'll leave it up to the Jetpack team to decide whether they want to fix the issues or disable the offending rules.