Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Business Hours Block: add missing Translators comment. #11281

Merged
merged 1 commit into from Feb 6, 2019
Merged

Business Hours Block: add missing Translators comment. #11281

merged 1 commit into from Feb 6, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Feb 5, 2019

Changes proposed in this Pull Request:

Follow-up from #10998
Merges r187076-wpcom
See D22463-code

Testing instructions:

  • Nothing should change with the block functionality.

Proposed changelog entry for your changes:

  • None

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Type] Dotcom Merge [Focus] i18n Internationalization / i18n, adaptation to different languages [Status] Tested on WP.com [Block] Business Hours labels Feb 5, 2019
@jeherve jeherve added this to the 7.1 milestone Feb 5, 2019
@jeherve jeherve self-assigned this Feb 5, 2019
@jeherve jeherve requested a review from a team as a code owner February 5, 2019 21:56
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D0-code before merging this PR. Thank you!

1 similar comment
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D0-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: March 5, 2019.
Scheduled code freeze: February 26, 2019

Generated by 🚫 dangerJS against 46a3036

brbrr
brbrr approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@brbrr brbrr merged commit 3671905 into master Feb 6, 2019
@brbrr brbrr deleted the fix/business-block-translator-comment branch February 6, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roccotripaldi roccotripaldi roccotripaldi approved these changes

@brbrr brbrr brbrr approved these changes

Assignees

@jeherve jeherve

Labels
[Block] Business Hours [Focus] i18n Internationalization / i18n, adaptation to different languages [Status] Tested on WP.com Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended [Type] Dotcom Merge
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeherve @matticbot @jetpackbot @roccotripaldi @brbrr