Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin search hints: fix issue where the first result was replaced #11482

Merged
merged 1 commit into from Mar 5, 2019
Merged

Plugin search hints: fix issue where the first result was replaced #11482

merged 1 commit into from Mar 5, 2019

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero self-assigned this Mar 5, 2019
@eliorivero eliorivero requested a review from a team as a code owner March 5, 2019 18:06
@eliorivero eliorivero added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] BLOCKER Plugin Search aka Feature Hints labels Mar 5, 2019
@jeherve jeherve added this to the 7.1.1 milestone Mar 5, 2019
@jetpackbot
Copy link

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 474d282

jeherve
jeherve approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to fix things on my end. 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 5, 2019
@jeherve jeherve merged commit 4f812a8 into master Mar 5, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 5, 2019
@jeherve jeherve deleted the fix/psh-replace-first-result branch March 5, 2019 20:20
jeherve pushed a commit that referenced this pull request Mar 5, 2019
@eliorivero @jeherve
Plugin search hints: fix issue where the first result was replaced (#…
b156262 
…11482)

This PR fixes an issue reported at

https://wordpress.org/support/topic/incompatibility-with-jetpack-3/
https://wordpress.org/support/topic/jetpack-over-writing-plugin-search-results/

where the first result was replaced by a hint.
@jeherve
Copy link
Member

jeherve commented Mar 5, 2019

Cherry-picked to branch-7.1 in b156262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@kraftbj kraftbj Awaiting requested review from kraftbj

Assignees

@eliorivero eliorivero

Labels
Plugin Search aka Feature Hints [Pri] BLOCKER [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.1.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eliorivero @jetpackbot @jeherve @matticbot