Subscription Form: fix the fallback to hide label in new browsers #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeherve
added
[Feature] Subscriptions
enejb
added a commit
that referenced
this pull request
Nov 13, 2014
enejb
added a commit
that referenced
this pull request
Nov 13, 2014
|
Both
Maybe we should use an alternative method, like this one: |
|
Should be fixed in master and branch-3.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #932, we added a fallback to hide the placeholder label we created for old browsers. Unfortunately, the label was still displayed in all browsers. The attached patch fixes things by hiding the label in all new browsers.