Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: PSR-4 the Attachments sync module #12707

Merged
merged 3 commits into from Jun 17, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jun 17, 2019

This PR allows for sync modules to be loadable via PSR-4, and updates the Attachments sync module to be loaded via PSR-4.

Changes proposed in this Pull Request:

  • Make the sync package modules directory compatible with PSR-4
  • Update the Attachments module

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • Part of the Jetpack DNA project - p1HpG7-70O-p2

Testing instructions:

  • Checkout the branch.
  • Enable WP_DEBUG_LOG.
  • Trigger a full sync.
  • Verify sync works well and you have no errors logged.
  • Verify tests pass and CI is green.

Proposed changelog entry for your changes:

  • Sync: PSR-4 the Attachments sync module

@tyxla tyxla added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Package] Sync [Focus] Jetpack DNA labels Jun 17, 2019
@tyxla tyxla added this to the 7.5 milestone Jun 17, 2019
@tyxla tyxla requested review from a team June 17, 2019 12:13
@tyxla tyxla requested a review from a team as a code owner June 17, 2019 12:13
@tyxla tyxla self-assigned this Jun 17, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against 1a9267e

Copy link
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy peasy lemon squeezy

@lezama
Copy link
Contributor

lezama commented Jun 17, 2019

waiting for the tests to pass before changing labels

@tyxla
Copy link
Member Author

tyxla commented Jun 17, 2019

and they passed ✅

@lezama lezama added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 17, 2019
@zinigor zinigor merged commit 647f516 into master Jun 17, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 17, 2019
@zinigor zinigor deleted the update/sync-psr4-modules-attachments branch June 17, 2019 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants