Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Package: Moves the Users and Themes sync module #12737

Merged
merged 1 commit into from Jun 19, 2019

Conversation

roccotripaldi
Copy link
Member

We are trying to move away from class mapped packages, and unspool all of the dependencies within a package.

So let's do this!

Part of #12712

Changes proposed in this Pull Request:

This PR should have no functional changes. The Users and Themes sync modules should function exactly the same as before.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

This modifies an existing part of Jetpack.

Testing instructions:

  • Try this branch out on a Jurassic.ninja site or on your docker testing site.
  • Connect the site and activate the recommended features.
  • Point your testing site to your .com sandbox to observe sync actions in real time.
  • Try a full sync and ensure there are no php errors in your site's error logs
  • Try adding, deleting, update some users on your site. Ensure you see the expected sync actions in the pipeline.

Proposed changelog entry for your changes:

  • None

@jetpackbot
Copy link

jetpackbot commented Jun 18, 2019

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 7b6d1cf

@roccotripaldi roccotripaldi force-pushed the add/users-themes-sync-modules-package branch 2 times, most recently from 1c406e5 to 67f1bf7 Compare June 18, 2019 20:08
@roccotripaldi roccotripaldi force-pushed the add/users-themes-sync-modules-package branch from 67f1bf7 to 7b6d1cf Compare June 18, 2019 21:24
@lezama lezama merged commit 76d6e59 into master Jun 19, 2019
@lezama lezama deleted the add/users-themes-sync-modules-package branch June 19, 2019 06:56
@jeherve jeherve added this to the 7.5 milestone Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants