Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack DNA: Move Sync Updates Module from Legacy to PSR-4 #12746

Merged
merged 1 commit into from Jun 19, 2019
Merged

Jetpack DNA: Move Sync Updates Module from Legacy to PSR-4 #12746

merged 1 commit into from Jun 19, 2019

Conversation

gititon
Copy link
Contributor

@gititon gititon commented Jun 18, 2019

This PR moves the sync updates module from legacy to PSR-4.

No new tests should be needed because this is a refactor, so existing tests should catch any regressions.

@gititon gititon requested a review from a team as a code owner June 18, 2019 21:43
@jetpackbot
Copy link

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against ca98713

@gititon gititon requested a review from a team June 18, 2019 21:54
@gititon gititon added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Jun 18, 2019
@roccotripaldi roccotripaldi mentioned this pull request Jun 18, 2019
Closed
20 tasks
@lezama lezama merged commit ef7fa7b into master Jun 19, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 19, 2019
@lezama lezama deleted the dna-updates-module branch June 19, 2019 11:14
@jeherve jeherve added this to the 7.5 milestone Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezama lezama lezama approved these changes

Assignees
No one assigned
Labels
[Focus] Jetpack DNA
Projects
None yet
Milestone
7.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gititon @jetpackbot @lezama @jeherve @matticbot