Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync: PSR-4 the sync listener #12762

Merged
merged 1 commit into from Jun 20, 2019
Merged

Sync: PSR-4 the sync listener #12762

merged 1 commit into from Jun 20, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Jun 19, 2019

In #12712 and all the related PRs we are making an effort to namespace all the sync modules. We also need to start namespacing the rest of the Sync core, see #12751.

This PR adds a namespace to the sync listener and that way autoload it with PSR-4.

Changes proposed in this Pull Request:

  • Sync: Namespace the sync listener and autoload it with PSR-4.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Part of the Jetpack DNA project - p1HpG7-70O-p2

Testing instructions:

  • Checkout the branch.
  • Enable WP_DEBUG_LOG.
  • Trigger a full sync.
  • Verify sync works well and you have no errors logged.
  • Verify tests pass and CI is green.

Proposed changelog entry for your changes:

  • Sync: Namespace the sync listener and load it with PSR-4

@tyxla tyxla added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Package] Sync [Focus] Jetpack DNA labels Jun 19, 2019
@tyxla tyxla added this to the 7.5 milestone Jun 19, 2019
@tyxla tyxla requested a review from a team June 19, 2019 13:54
@tyxla tyxla requested review from a team as code owners June 19, 2019 13:54
@tyxla tyxla self-assigned this Jun 19, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: July 2, 2019.
Scheduled code freeze: June 25, 2019

Generated by 🚫 dangerJS against afc98b5

Copy link
Member

@roccotripaldi roccotripaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, i tried it with full sync and incremental sync.

Copy link
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lezama lezama merged commit 4fc9423 into master Jun 20, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 20, 2019
@lezama lezama deleted the update/sync-psr4-listener branch June 20, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants