Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct inline documentation "Array" type #15581

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Correct inline documentation "Array" type #15581

merged 1 commit into from
Apr 28, 2020

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Apr 27, 2020

Change inline documentation types of Array to array. The current version is confusing to some IDEs.

Proposed changelog entry for your changes:

  • Updated inline PHP documentation to correctly indicate the array type.

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review
⚠️ "Testing instructions" are missing for this PR. Please add some

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against f2687bf

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial Docs labels Apr 27, 2020
@jeherve jeherve added this to the 8.5 milestone Apr 27, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 27, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello desrosj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D42517-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@jeherve jeherve merged commit 62555f3 into Automattic:master Apr 28, 2020
@matticbot matticbot added [Status] Needs Changelog [Status] Needs Package Release This PR made changes to a package. Let's update that package now. and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 28, 2020
@desrosj desrosj deleted the correct-array-type-inline-docs branch April 28, 2020 12:24
@kraftbj
Copy link
Contributor

kraftbj commented Apr 29, 2020

r206617-wpcom

@jeherve jeherve removed the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
Docs Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@desrosj @jetpackbot @matticbot @kraftbj @jeherve