Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Media: Fix Modal focus loss on arrow keypress #16055

Merged
merged 6 commits into from
Jun 9, 2020
Merged

External Media: Fix Modal focus loss on arrow keypress #16055

merged 6 commits into from
Jun 9, 2020

Commits on Jun 9, 2020

  1. Contain arrow keys within the External Media Modal

    @WunderBart
    WunderBart committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    598f54f View commit details
    Browse the repository at this point in the history

  2. Handle arrow propagation directly via content element

    @WunderBart
    WunderBart committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    ab9d7af View commit details
    Browse the repository at this point in the history

  3. Link to issue for tracking purposes

    @WunderBart
    WunderBart committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    7ff7184 View commit details
    Browse the repository at this point in the history

  4. Remove onMouseDown propagation stopper 

    It is already being stopped by the IsolatedEventContainer that is wrapping the frame of the modal.
    @WunderBart
    WunderBart committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    41de2b9 View commit details
    Browse the repository at this point in the history

  5. Re-attach keys handler to Modal parent

    @WunderBart
    WunderBart committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    c6c9171 View commit details
    Browse the repository at this point in the history

  6. replace global querySelector with scoped one

    @marekhrabe
    marekhrabe committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    d5cc32d View commit details
    Browse the repository at this point in the history