-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Media: Show for empty galleries #16288
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16288 Scheduled Jetpack release: July 7, 2020. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me. 🚢
r209630-wpcom |
This PR fixes a regression introduced in d2c4f68, where External Media would not be available for empty galleries.
Fixes #16069 (comment)
Changes proposed in this Pull Request:
value
like an array and check for the amount of items it contains.Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Proposed changelog entry for your changes: