Fix Image Compare block in AMP when width/height are not available #17253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16093
See #14395
All elements in AMP need to have dimensions defined up-front so that the page will have static layout to avoid CLS (Cumulative Layout Shift). When no
width
orheight
is available for the Image Compare block, instead of omitting thewidth
/height
for theamp-image-slider
component, the correct AMP fallback is to provide fallback dimensions. Since we don't know what the image dimension is, providing an aspect ratio of 1:1 seems to make sense.Changes proposed in this Pull Request:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Add an Image Compare block to a post and view that post on an AMP page.
I'm not sure entirely why the
width
orheight
weren't available when callingrender_amp()
, so the only way I know to test this is to forcibly unset them when calling the function:Proposed changelog entry for your changes: