-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PHPCS: Modules, endpoints, and general files #17619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggested test cases for this PR.
Publicize
- Publish a post with Twitter integration
- Publish a post with Facebook integration
- Publish a post to all integrations at once
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
After 9.1 branches off and #17406 merges, we need to update base branch to |
Caution: This PR has changes that must be merged to WordPress.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me.
Of the files in this patch currently listed by Fusion as not being in sync and where we're removing use
statements,
- _inc/lib/core-api/wpcom-endpoints/class-wpcom-rest-api-v2-endpoint-tweetstorm-gather.php reports no diff.
- modules/search/class-jetpack-instant-search.php shows no uses of those
use
s in the diff. - modules/shortcodes/instagram.php reports no diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a manual rebase after #17595. Otherwise should be good.
add_action( 'edit_form_top', 'Jetpack\EditorType\remember_classic_editor' ); | ||
add_filter( 'block_editor_settings', 'Jetpack\EditorType\remember_block_editor', 10, 2 ); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lost a newline here in the rebase. Probably doesn't matter.
Scheduled Jetpack release: November 10, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17619 Thank you for the great PR description! When this PR is ready for review, please apply the |
r216013-wpcom |
After #17406, updated the "requiredlist" files to match new PHPCS rules for packages and the debugger.
Changes proposed in this Pull Request:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
n/a
Proposed changelog entry for your changes: