Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated PHPCS: Blocks #17620

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Updated PHPCS: Blocks #17620

merged 1 commit into from
Oct 28, 2020

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 26, 2020

After #17406, updated the "requiredlist" files to match new PHPCS rules for blocks.

Changes proposed in this Pull Request:

  • PHPCS

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

n/a

Testing instructions:

n/a

Proposed changelog entry for your changes:

  • n/a

@kraftbj kraftbj added this to the 9.2 milestone Oct 26, 2020
@kraftbj kraftbj self-assigned this Oct 26, 2020
@kraftbj kraftbj added [Status] Blocked / Hold [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial labels Oct 26, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D51820-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

anomiex
anomiex previously approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@anomiex anomiex removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Oct 27, 2020
Base automatically changed from add/phpcs-rules-from-MediaWiki to master October 27, 2020 20:32
@kraftbj kraftbj dismissed anomiex’s stale review October 27, 2020 20:32

The base branch was changed.

@github-actions github-actions bot added the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Oct 27, 2020
@kraftbj kraftbj added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Blocked / Hold labels Oct 27, 2020
anomiex
anomiex previously approved these changes Oct 28, 2020
View reviewed changes
@anomiex anomiex added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 28, 2020
@jetpackbot
Copy link

Scheduled Jetpack release: November 10, 2020.
Scheduled code freeze: November 3, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17620

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 1279b45

@kraftbj kraftbj merged commit f3f6887 into master Oct 28, 2020
@kraftbj kraftbj deleted the phpcs/pr-4 branch October 28, 2020 18:50
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 28, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 28, 2020

r216011-wpcom

@kraftbj kraftbj removed the [Status] Needs Package Release This PR made changes to a package. Let's update that package now. label Oct 28, 2020
@kraftbj kraftbj mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anomiex anomiex anomiex approved these changes

@sergeymitr sergeymitr sergeymitr approved these changes

Assignees

@kraftbj kraftbj

Labels
Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
9.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kraftbj @matticbot @jetpackbot @anomiex @sergeymitr @jeherve