Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMP infinite scroll add hidden #17778

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

pereirinha
Copy link
Contributor

@westonruter,

I'm assigning this PR to extend #17497 and provide support for elements that are supposed to be hidden on initial load, in case Infinite Scroll is enabled — like the pagination bar.

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended AMP [Feature] Infinite Scroll labels Nov 11, 2020
Copy link
Collaborator

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeherve jeherve merged commit 118e11a into fix/amp-infinite-scroll Nov 12, 2020
@jeherve jeherve deleted the fix/amp-infinite-scroll-add-hidden branch November 12, 2020 17:21
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 12, 2020
@jeherve jeherve added this to the 9.2 milestone Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMP [Feature] Infinite Scroll Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants