-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin Color Schemes: Block Editor Support #18010
Conversation
Scheduled Jetpack release: January 12, 2021. Thank you for the great PR description! When this PR is ready for review, please apply the |
ba2b296
to
149d9d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems straightforward enough. I see @frontdevde already tested.
81f9843
to
4f81208
Compare
The base branch was changed.
149d9d2
to
8ce7f60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again after rebase 👍
Caution: This PR has changes that must be merged to WordPress.com |
after some fight with the build process on wpcom, r218390-wpcom |
The general support for admin color schemes is being added in #17828. This specific PR extends it so the color schemes also apply to the block editor, just as core color schemes.
Changes proposed in this Pull Request:
Jetpack product discussion
—
Does this pull request change what data or activity we track or use?
No
Testing instructions:
A few examples of the green color propagating from the Sakura scheme:
Compared to the Sunset scheme:
Proposed changelog entry for your changes:
—
Fixes #18016