Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Color Schemes: Block Editor Support #18010

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

marekhrabe
Copy link
Contributor

@marekhrabe marekhrabe commented Dec 8, 2020

The general support for admin color schemes is being added in #17828. This specific PR extends it so the color schemes also apply to the block editor, just as core color schemes.

Changes proposed in this Pull Request:

  • uses Sass variables to generate CSS vars the block editor uses to adjust its colors

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

A few examples of the green color propagating from the Sakura scheme:

Screenshot 2020-12-08 at 15 21 16 Screenshot 2020-12-08 at 15 21 25 Screenshot 2020-12-08 at 15 21 21

Compared to the Sunset scheme:

Screenshot 2020-12-08 at 15 43 10 Screenshot 2020-12-08 at 15 42 53 Screenshot 2020-12-08 at 15 43 43

Proposed changelog entry for your changes:

Fixes #18016

@jetpackbot
Copy link

jetpackbot commented Dec 8, 2020

Scheduled Jetpack release: January 12, 2021.
Scheduled code freeze: January 4, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 8ce7f60

@frontdevde frontdevde added this to the 9.3 milestone Dec 8, 2020
@frontdevde frontdevde self-requested a review December 9, 2020 08:07
@frontdevde frontdevde force-pushed the add/admin-color-schemes-gutenberg branch from ba2b296 to 149d9d2 Compare December 9, 2020 08:58
frontdevde
frontdevde previously approved these changes Dec 9, 2020
Copy link
Contributor

@frontdevde frontdevde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

I rebased with feature branch and changed to use the highlight color so it matches with the button color of the color scheme.

e.g. with Classic Bright the button color of the scheme is pink

Screenshot 2020-12-09 at 09 54 14

Using $base-color the buttons were blue, now with $highlight-color they are pink too.

Before After
Screenshot 2020-12-09 at 09 56 48 Screenshot 2020-12-09 at 09 55 36

@cpapazoglou cpapazoglou added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Team Review labels Dec 9, 2020
@cpapazoglou cpapazoglou linked an issue Dec 9, 2020 that may be closed by this pull request
anomiex
anomiex previously approved these changes Dec 9, 2020
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems straightforward enough. I see @frontdevde already tested.

@anomiex anomiex added [Pri] Normal [Status] Ready to Merge Go ahead, you can push that green button! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 9, 2020
Base automatically changed from try/admin-color-schemes to master December 14, 2020 10:49
@frontdevde frontdevde dismissed stale reviews from anomiex and themself December 14, 2020 10:49

The base branch was changed.

@marekhrabe marekhrabe force-pushed the add/admin-color-schemes-gutenberg branch from 149d9d2 to 8ce7f60 Compare December 15, 2020 08:48
Copy link
Contributor

@frontdevde frontdevde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after rebase 👍

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello marekhrabe! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D54279-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@marekhrabe marekhrabe merged commit 7de87ef into master Dec 15, 2020
@marekhrabe marekhrabe deleted the add/admin-color-schemes-gutenberg branch December 15, 2020 09:44
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 15, 2020
@marekhrabe
Copy link
Contributor Author

after some fight with the build process on wpcom, r218390-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav unification: ensure new color schemes apply to Gutenberg
7 participants