P2: rename the ready.o2 event to ready_p2
#18347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: jQuery 3.5.1 handles the `ready.o2` event in terms of the `ready` event, thus breaks the P2 Test Plan: manual 1. update your sandbox to jQuery 3.5.1 ( D54601 ) 1. apply D54878 before this patch 1. sandbox a P2 1. check whether there are any errors Reviewers: naxoc Reviewed By: naxoc Tags: #touches_jetpack_files Differential Revision: D54524-code This commit syncs r219004-wpcom.
jeherve
added
[Type] Bug
|
Scheduled Jetpack release: February 2, 2021. Thank you for the great PR description! When this PR is ready for review, please apply the |
kraftbj
approved these changes
Jan 19, 2021
kraftbj
added
[Status] Ready to Merge
|
Refreshed the branch since we've been fixing a number of things related to actions and there were some failures. This is good to merge once everything lights up green. |
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D54524-code
This commit syncs r219004-wpcom.
Changes proposed in this Pull Request:
jQuery 3.5.1 handles the
ready.o2event in terms of thereadyevent, thus breaks the P2Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Proposed changelog entry for your changes: