Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS: Don't lint photon-cdn/jetpack-manifest.php #18400

Merged
merged 1 commit into from Jan 19, 2021

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 18, 2021

Changes proposed in this Pull Request:

PHPCS: Don't lint photon-cdn/jetpack-manifest.php

It's a built file since #18313 / #18257.

Jetpack product discussion

None.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Do something like composer phpcs:lint projects/plugins/jetpack/modules/photon-cdn/jetpack-manifest.php. It should not output any warnings because the file is excluded.

Proposed changelog entry for your changes:

  • None needed.

@anomiex anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Jan 18, 2021
@anomiex anomiex self-assigned this Jan 18, 2021
@jetpackbot
Copy link

Scheduled Jetpack release: February 2, 2021.
Scheduled code freeze: January 25, 2021

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against d191ed8

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jan 18, 2021
@kraftbj kraftbj added this to In Progress in Repo Reorg via automation Jan 18, 2021
@kraftbj kraftbj added this to the 9.4 milestone Jan 19, 2021
@kraftbj kraftbj merged commit 54357bf into master Jan 19, 2021
Repo Reorg automation moved this from In Progress to Done Jan 19, 2021
@kraftbj kraftbj deleted the fix/dont-lint-photon-cdn-jetpack-manifest branch January 19, 2021 05:52
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants