-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add install command #18504
CLI: Add install command #18504
Conversation
@anomiex I want to DRY out the command a bit, but end of my day so wanted to push up to get a gut check that this makes you happy wrt the github action providing verbose output. https://github.com/Automattic/jetpack/pull/18504/checks?check_run_id=1826705537 |
Haven't checked the code yet, but the verbose output looks fine to me. If I were writing an action-specific tool I'd put a |
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Going to land this. If there are more issues, this is under active iteration and we'll keep with it. |
tools/cli/commands/install.js
Outdated
* @param {object} tasks - The tasks object | ||
* | ||
* @returns {object} An array of either the root install task or empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @param {object} tasks - The tasks object | |
* | |
* @returns {object} An array of either the root install task or empty. | |
* @param {Array} tasks - The tasks array | |
* | |
* @returns {Array} The tasks array, which may have been modified. |
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
PR #18504 increased the limit for one job that was consistently hitting the old 5-minute timeout, but not the other two. Lately I've been noticing that one of those other two has been barely hitting the timeout too on occasion, and I see the other is at ~4:30 too, so let's bump them too.
PR #18504 increased the limit for one job that was consistently hitting the old 5-minute timeout, but not the other two. Lately I've been noticing that one of those other two has been barely hitting the timeout too on occasion, and I see the other is at ~4:30 too, so let's bump them too.
Changes proposed in this Pull Request:
jetpack install
which runscomposer install
andyarn install
if composer.json or package.json are present in a project.Also, prettifies the build step:
Screen.Recording.2021-01-22.at.5.26.01.PM.mov
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
n/a
Testing instructions:
yarn install
for the initial install.yarn cli-link
or prefix all of the commands below with.tools/cli/bin/
, e.g../tools/cli/bin/jetpack install --help
.jetpack
to see all help commands.jetpack install --help
to see the install commands.jetpack install
to get a project picker.jetpack install --root
to get a project picker and install the monorepo root too.jetpack install monorepo
to install the monorepo root without a project.jetpack install packages/connection
to install that particular package.jetpack install packages/connection --root
to install a particular package and the repo root.jetpack build plugins/jetpack
to see the new build prettification.Proposed changelog entry for your changes:
Screen.Recording.2021-01-22.at.3.19.34.PM.mov