Avoid creating jetpack-temp directory in WP root

[szepeviktor]

Fixes #mypain

Changes proposed in this Pull Request:

Try to create jetpack-temp directory in wp-content in the first place.

Some background

I'd like to keep all installations highly clean: git + Composer + separate directory for WordPress core files.

(🖼️ file change alert notification)

So the document root contains 2 directories:

1. core
2. and wp-content

It needs 2 lines in wp-config.
https://wordpress.org/support/article/giving-wordpress-its-own-directory/

As of today Jetpack writes into core's directory (ABSPATH).
This PR prioritizes uploads and wp-content directory.

[szepeviktor]

Error: Project packages/backup is being changed, but no change file in projects/packages/backup/changelog/ is touched!

I've been pwnd! Could you help me phrase a line for the changelog?

[jeherve]

I've been pwnd! Could you help me phrase a line for the changelog?

You should be able to follow the instructions here:
https://github.com/Automattic/jetpack/blob/master/docs/monorepo.md#using-the-jetpack-changelogger

Go to that project and use vendor/bin/changelogger add to add a change file.

[szepeviktor]

Jeremy! That is SO HARD!!!

[szepeviktor]

@jeherve Done 🍏🍏

[jeherve]

Done 🍏🍏

Thank you! We'll take a look and review soon.

Internal reference: p1615830698055600-slack-CS8UYNPEE

[vianasw]

Thanks for the PR. While we think that this could work, it would directly affect so many sites and we can't be sure if that it's not going to break anything. We think that an approach using a constant would work better in this case (i.e., if there is an install location constant define use that, otherwise fall back to what we have now).

[szepeviktor]

All right.

👑

I leave it up to you.

BTW This is the new constant: an immutable configuration.

// Define constant values.
Config::init(
    [
        'version' => '1.0.0',
        'filePath' => __FILE__,
        'baseName' => plugin_basename(__FILE__),
        'slug' => 'plugin-slug',
    ]
);

https://github.com/szepeviktor/small-project/blob/master/src/Config.php

[szepeviktor]

@jeherve Friendly ping 🏓

[jeherve]

I'm afraid I have no news for you. The discussion above still applies:
#19162 (review)

[szepeviktor]

Thank you for your response.

I close this PR.