Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: add new filter to turn off Pin it button on hover #2020

Merged
merged 2 commits into from May 17, 2015

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 24, 2015

See https://wordpress.org/support/topic/jp-v35-sharing-pinterest-button-overlay for the original request.

The Pin it button can then be disabled with add_filter( 'jetpack_pinit_over_button', '__return_false' );

Related commit: 91c4a7b

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons Team Partnerships labels Apr 24, 2015
@jeherve jeherve added this to the 3.5.1 milestone Apr 24, 2015
@jeherve jeherve added [Status] In Progress [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 24, 2015
@samhotchkiss samhotchkiss modified the milestones: 3.6, 3.5.1 Apr 29, 2015
@jkudish
Copy link
Contributor

jkudish commented May 2, 2015

Looks good to me 👍

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 5, 2015
/**
* Filter the Pin it button appearing when hovering over images when using the official button style.
*
* @since 3.5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change it to 3.6 since it's not yet in master?

@zinigor
Copy link
Member

zinigor commented May 15, 2015

Tested, looks good, after changing the version number (and a typo defailt => default) feel free to merge.

jeherve added a commit that referenced this pull request May 17, 2015
Sharing: add new filter to turn off Pin it button on hover
@jeherve jeherve merged commit 0361f17 into Automattic:master May 17, 2015
@jeherve jeherve removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 17, 2015
@jeherve jeherve deleted the add_pinit_hover_filter branch May 17, 2015 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Post sharing, sharing buttons [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants