Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetpack Boost plugin #20512

Merged
merged 23 commits into from
Jul 31, 2021
Merged

Add Jetpack Boost plugin #20512

merged 23 commits into from
Jul 31, 2021

Conversation

gravityrail
Copy link
Contributor

This is part of our work to support easier sharing of design elements via Jetpack RNA and in generate to improve collaboration between Jetpack ecosystem plugins, as well as making it easier to onboard Jetpack developers.

Changes proposed in this Pull Request:

  • Add Jetpack Boost to the Jetpack monorepo

Jetpack product discussion

TODO

Does this pull request change what data or activity we track or use?

No

Testing instructions:

TODO

@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Jul 30, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 30, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Boost plugin:

  • Next scheduled release: August 3, 2021.
  • Scheduled code freeze: July 26, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jul 30, 2021
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave the structure of it a once-over. A lot of it is identifying things that can probably be deleted.

I note you didn't import any history of the old repo. Just confirming, was that intentional?

@@ -0,0 +1,37 @@
/.wordpress-org
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file is needed. We don't use wp dist-archive to create the plugin zip.

But you'll probably want to look at this file for ideas on what you need to tag with "production-include" and "production-exclude" in .gitattributes:

  • Anything listed here that's not already in .gitignore (and doesn't get deleted with the move to the monorepo) should get "production-exclude".
  • Anything that's in .gitignore but not in this file should get "production-include". Most notably, you'll want to look at the production-include rules that the other plugins use to get stuff from vendor/ included in the plugin zip.

P.S. Once you get the Build workflow passing, you can see the would-be contents of the plugin zip in the "jetpack-build" artifact produced by that workflow.

@@ -0,0 +1,33 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this file for?

@@ -0,0 +1,4 @@
############################################
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything in projects/plugins/jetpack-boost/.github/ should probably be deleted. We generally configure the mirror repo to not allow issues in the first place, and to auto-close PRs with a pointer to the monorepo. Similarly, tools like renovate and stale are run in the monorepo rather than the mirror.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted most of it, but left the things that we may still want to pull things from for now. 20530e1

@@ -0,0 +1,88 @@
name: Integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one might be worth moving into the monorepo's .github/workflows/. Unfortunately we don't have any infrastructure yet for running E2E tests.

projects/plugins/jetpack-boost/.husky/.gitignore Outdated Show resolved Hide resolved
projects/plugins/boost/package.json Outdated Show resolved Hide resolved
projects/plugins/boost/package.json Outdated Show resolved Hide resolved
projects/plugins/boost/docs/DEVELOPERS.md Outdated Show resolved Hide resolved
projects/plugins/boost/docs/DEVELOPERS.md Outdated Show resolved Hide resolved
projects/plugins/boost/readme.txt Show resolved Hide resolved
@gravityrail
Copy link
Contributor Author

@anomiex

I note you didn't import any history of the old repo. Just confirming, was that intentional?

Yes

@kraftbj kraftbj added this to the boost/1.2.0 milestone Jul 31, 2021
@github-actions github-actions bot added the Actions GitHub actions used to automate some of the work around releases and repository management label Jul 31, 2021
@kraftbj kraftbj removed the Actions GitHub actions used to automate some of the work around releases and repository management label Jul 31, 2021
@kraftbj kraftbj added [Type] Janitorial and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 31, 2021
@kraftbj kraftbj merged commit 6c406da into master Jul 31, 2021
@kraftbj kraftbj deleted the add/jetpack-boost branch July 31, 2021 07:31
@github-actions github-actions bot added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jul 31, 2021
@thingalon
Copy link
Member

Wow, thank you for handling the complex work of merging all the things, @kraftbj, @gravityrail and @anomiex!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Boost A feature to speed up the site and improve performance. Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants