-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jetpack Boost plugin #20512
Add Jetpack Boost plugin #20512
Conversation
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Boost plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave the structure of it a once-over. A lot of it is identifying things that can probably be deleted.
I note you didn't import any history of the old repo. Just confirming, was that intentional?
@@ -0,0 +1,37 @@ | |||
/.wordpress-org |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this file is needed. We don't use wp dist-archive
to create the plugin zip.
But you'll probably want to look at this file for ideas on what you need to tag with "production-include" and "production-exclude" in .gitattributes
:
- Anything listed here that's not already in
.gitignore
(and doesn't get deleted with the move to the monorepo) should get "production-exclude". - Anything that's in
.gitignore
but not in this file should get "production-include". Most notably, you'll want to look at the production-include rules that the other plugins use to get stuff fromvendor/
included in the plugin zip.
P.S. Once you get the Build workflow passing, you can see the would-be contents of the plugin zip in the "jetpack-build" artifact produced by that workflow.
@@ -0,0 +1,33 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this file for?
@@ -0,0 +1,4 @@ | |||
############################################ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything in projects/plugins/jetpack-boost/.github/
should probably be deleted. We generally configure the mirror repo to not allow issues in the first place, and to auto-close PRs with a pointer to the monorepo. Similarly, tools like renovate and stale are run in the monorepo rather than the mirror.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted most of it, but left the things that we may still want to pull things from for now. 20530e1
@@ -0,0 +1,88 @@ | |||
name: Integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one might be worth moving into the monorepo's .github/workflows/
. Unfortunately we don't have any infrastructure yet for running E2E tests.
Yes |
It needs `## ...` headers, not `= ... =`.
cf5d551
to
49a511f
Compare
Wow, thank you for handling the complex work of merging all the things, @kraftbj, @gravityrail and @anomiex! |
This is part of our work to support easier sharing of design elements via Jetpack RNA and in generate to improve collaboration between Jetpack ecosystem plugins, as well as making it easier to onboard Jetpack developers.
Changes proposed in this Pull Request:
Jetpack product discussion
TODO
Does this pull request change what data or activity we track or use?
No
Testing instructions:
TODO