Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publicize: store connection into post meta #21161

Closed
wants to merge 34 commits into from

Conversation

retrofox
Copy link
Contributor

Fixes #

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@retrofox retrofox added [Feature] Publicize Now Jetpack Social, auto-sharing [Status] In Progress [Size] M [Extension] Publicize Block editor plugin labels Sep 22, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: October 5, 2021.
  • Scheduled code freeze: September 28, 2021.

@retrofox retrofox changed the base branch from update/publicize-refresh-social-media-connections to master September 22, 2021 22:36
Copy link
Contributor

@pablinos pablinos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, although it would be great if there was a better way to handle the selectors.

Should we add this as a change to the other PR?

* @returns {Array} List of connections.
*/
export function getFailedConnections( state ) {
return state.connections.filter( connection => false === connection.test_success );
export function getFailedConnections() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these selectors don't accept state as the first parameter, is that an issue? As they are called on the store, state will be passed in.

@jeherve
Copy link
Member

jeherve commented Mar 29, 2023

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] Publicize Block editor plugin [Feature] Publicize Now Jetpack Social, auto-sharing [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Size] M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants