Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Touch all the things! #21191

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Sep 24, 2021

Trying to test #21188 by making a PR that touches every directory that
triggers a label addition.

Trying to test #21188 by making a PR that touches every directory that
triggers a label addition.
@anomiex anomiex added the DO NOT MERGE don't merge it! label Sep 24, 2021
@anomiex anomiex requested a review from a team as a code owner September 24, 2021 17:02
Copy link

@test-case-reminder test-case-reminder bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Connection

  • In-place connection with free plan
  • In-place connection with paid plan
  • In-place connection with product purchase
  • Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
  • Disconnect/reconnect connection
  • Secondary user connection
  • Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

  • WooCommerce Payments
  • Jetpack Boost
  • Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello anomiex! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D67381-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • 🔴 Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • 🔴 Add testing instructions.
  • 🔴 Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please edit your PR description and explain what functional changes your PR includes, and why those changes are needed.


🔴 Action required: Please include detailed testing steps, explaining how to test your change, like so:

#### Testing instructions:

* Go to '..'
*

🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so:

#### Does this pull request change what data or activity we track or use?

My PR adds *x* and *y*.

🔴 Action required: Please add missing changelog entries for the following projects: projects/github-actions/pr-is-up-to-date, projects/github-actions/push-to-mirrors, projects/github-actions/repo-gardening, projects/github-actions/required-review, projects/js-packages/api, projects/js-packages/base-styles, projects/js-packages/components, projects/js-packages/connection, projects/js-packages/eslint-changed, projects/js-packages/storybook, projects/packages/a8c-mc-stats, projects/packages/abtest, projects/packages/analyzer, projects/packages/assets, projects/packages/autoloader, projects/packages/backup, projects/packages/blocks, projects/packages/changelogger, projects/packages/codesniffer, projects/packages/compat, projects/packages/config, projects/packages/connection-ui, projects/packages/connection, projects/packages/constants, projects/packages/device-detection, projects/packages/error, projects/packages/heartbeat, projects/packages/identity-crisis, projects/packages/jitm, projects/packages/lazy-images, projects/packages/licensing, projects/packages/logo, projects/packages/options, projects/packages/partner, projects/packages/password-checker, projects/packages/post-list, projects/packages/redirect, projects/packages/roles, projects/packages/status, projects/packages/sync, projects/packages/terms-of-service, projects/packages/tracking, projects/plugins/backup, projects/plugins/beta, projects/plugins/boost, projects/plugins/debug-helper, projects/plugins/jetpack, projects/plugins/search, projects/plugins/vaultpress

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Sep 24, 2021
@anomiex anomiex closed this Oct 11, 2021
@anomiex anomiex deleted the test/touch-all-the-things branch October 11, 2021 17:06
@anomiex anomiex restored the test/touch-all-the-things branch January 5, 2022 21:10
@anomiex anomiex reopened this Jan 5, 2022
@anomiex anomiex closed this Jan 5, 2022
@anomiex anomiex deleted the test/touch-all-the-things branch January 5, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE don't merge it! [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants