Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of useInnerBlocksProps API #21625

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Nov 2, 2021

This fixes an error caused by __experimentalUseInnerBlocksProps now becoming useInnerBlocksProps, which occurred in WordPress/gutenberg#26031 (specifically this line).

Changes proposed in this Pull Request:

  • Update usage of __experimentalUseInnerBlocksProps to useInnerBlocksProps

Jetpack product discussion

p9ugOq-1Tb-p2

Does this pull request change what data or activity we track or use?

Not, it does not.

Testing instructions:

See wordpress-mobile/gutenberg-mobile#4196

Formerly `__experimentalUseInnerBlocksProps`, the API has now become `useInnerBlocksProps` so we update usage.
@guarani guarani added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Nov 2, 2021
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello guarani! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D69473-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@guarani guarani changed the base branch from master to rnmobile/add/tiled-gallery-block November 2, 2021 18:23
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: December 7, 2021.
  • Scheduled code freeze: November 30, 2021.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 2, 2021
@guarani guarani changed the title Rnmobile/fix/tiled gallery inner block api Update usage of useInnerBlocksProps API Nov 2, 2021
@guarani guarani marked this pull request as ready for review November 2, 2021 19:05
@guarani
Copy link
Contributor Author

guarani commented Nov 2, 2021

PR is up to date — This PR needs a master merge or rebase.

I've never ran into this check failing before. It looks like the failure is caused by this line returning false:

git merge-base --is-ancestor 8ed26f2cab1858e43011d6226009a6b41e991b36 744a6ec96685c83d1e3593002c222c4b853480a6

It's true 8ed26f2 (a recent commit on trunk) is not an ancestor of this PR's head commit 744a6ec; however, I think that's expected (or common) on feature branches like this one.

@guarani
Copy link
Contributor Author

guarani commented Nov 2, 2021

It's true 8ed26f2 (a recent commit on trunk) is not an ancestor of this PR's head commit 744a6ec; however, I think that's expected (or common) on feature branches like this one.

I think this check, PR is up to date, is only triggered when a PR targets master. When this PR was opened, it incorrectly targeted master but was then updated to target the feature branch. That would explain why I don't see this check on other PRs targeting feature branches (e.g. #21620), but do see it on PRs targeting master (e.g. #21627).

In summary, I think this can be safely ignored, as with the other failing checks.

Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly for me to fix the error on both platforms 🎉

@guarani guarani merged commit fce473f into rnmobile/add/tiled-gallery-block Nov 3, 2021
@guarani guarani deleted the rnmobile/fix/tiled-gallery-inner-block-api branch November 3, 2021 14:33
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tiled Gallery [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants