Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instant Search: ensure the hidden overlay doesn't add whitespace to printed pages #22134

Closed
wants to merge 93 commits into from

Conversation

bluefuton
Copy link
Contributor

@bluefuton bluefuton commented Dec 20, 2021

Fixes https://github.com/Automattic/jpop-issues/issues/7134.

Note: this PR is branched off #21637.

The only confirmed theme that this has happened on is 'Field Guide' but there may be others.

Changes proposed in this Pull Request:

Ensure the search overlay is completely hidden on printed pages.

On certain themes, the overlay's presence can cause blank pages to be added to the printout.

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  1. Open a site with Instant Search installed. Don't start a search.
  2. Bring up the print preview for the page.
  3. Ensure there are no extra blank pages added by the hidden overlay.
  4. Inspect the print styles in the browser and ensure that 'display:none' is applied to '.jetpack-instant-search__overlay'.

@bluefuton bluefuton changed the base branch from master to update/move-classic-and-instant-search-to-package December 20, 2021 03:51
@github-actions
Copy link
Contributor

github-actions bot commented Dec 20, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: January 11, 2022.
  • Scheduled code freeze: January 3, 2022.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Dec 20, 2021
@kangzj
Copy link
Contributor

kangzj commented Dec 20, 2021

When I change rendering to print, the style is applied correctly:
image

And the change seems safe to me, so feel free to merge when you are ready 👍

jsnmoon
jsnmoon previously approved these changes Dec 20, 2021
Copy link
Member

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described!

@jsnmoon jsnmoon added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Dec 20, 2021
@bluefuton bluefuton changed the base branch from update/move-classic-and-instant-search-to-package to master December 21, 2021 02:32
@bluefuton bluefuton dismissed jsnmoon’s stale review December 21, 2021 02:32

The base branch was changed.

@bluefuton bluefuton added [Status] In Progress and removed [Status] Ready to Merge Go ahead, you can push that green button! Touches WP.com Files labels Dec 21, 2021
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Focus] Compatibility Ensuring our products play well with third-parties [Feature] Extra Sidebar Widgets Unit Tests labels Dec 21, 2021
@bluefuton bluefuton removed [Feature] Extra Sidebar Widgets [Focus] Compatibility Ensuring our products play well with third-parties labels Dec 21, 2021
@bluefuton
Copy link
Contributor Author

Will create a fresh PR branched off master instead of trying to navigate this rebase mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants