-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Fix Tiled Gallery JS test failure #22252
[RNMobile] Fix Tiled Gallery JS test failure #22252
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Summary of failing tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this @guarani 🙇♀️
Fixes failing JS test that was introduced by a bug in https://github.com/Automattic/jetpack/pull/21767/files. The failing test is:
Related:
Changes proposed in this Pull Request:
master
, it's only on our feature branch).Jetpack product discussion
p9ugOq-1Tb-p2
Does this pull request change what data or activity we track or use?
No, it does not.
Testing instructions:
Verify that the
JS tests
CI check passes. The "Code coverage" test may fail for different reasons, as long as it doesn't fail due to the above error.