New Admin Page: My Jetpack (connection management) #2252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds the Jetapck connection information about the logged in user and the master user to My Connection page - Admins can disconnect the Jetpack site, or their own link to wpcom - Will display who is the Master user for a site - Admins who are not master user will be able to set themselves as master - Other users can link/unlink their accounts New file: _inc/jp-connection.js New file: class.jetpack-my-jetpack-page.php New file: my-jetpack-page.php
We want to funnel user traffic to disconnect their site to the “My Connection” page so we can provide them with additional options and support before they disconnect
When a user wants to disconnect their site they will now see a message that gives them the opportunity to first seek support.
file/element refactor to now call the page "My Jetpack" instead of My Connection
Refactor to remove some DRYness, better naming conventions, better organization. Created an additional function to handle the current user logic and separated it from the master user logic. It now is easier to read.
Restructuring HTML + styling connection details adding html + styles to connection page responsive styling for connection page More detailed styling for connection actions formatting scss for best performance Header nav btn adjustments for small mobile devices. adding ellipsis overflow to usernames that are longer than a specified length. adjusting max width of usernames
styling changes to connection 'tables' Finding the best way to layout page
Cleaning up unneeded styles more style refinements Style adjustments for small mobile
dereksmart
added
[Type] Enhancement
dereksmart
added
[Status] In Progress
[Status] Needs Review
| <script id="tmpl-connection-page" type="text/html"> | ||
| <div class="content-container"> | ||
| <div id="my-jetpack-content" class="content"> | ||
| <h2><?php _e( 'Jetpack Connection Status' ); ?></h2> |
There was a problem hiding this comment.
Seems like there is a missing jetpack textdomain here.
When a user wants to disconnect their site they will now see a message that gives them the opportunity to first seek support.
file/element refactor to now call the page "My Jetpack" instead of My Connection
Refactor to remove some DRYness, better naming conventions, better organization. Created an additional function to handle the current user logic and separated it from the master user logic. It now is easier to read.
Restructuring HTML + styling connection details adding html + styles to connection page responsive styling for connection page More detailed styling for connection actions formatting scss for best performance Header nav btn adjustments for small mobile devices. adding ellipsis overflow to usernames that are longer than a specified length. adjusting max width of usernames
styling changes to connection 'tables' Finding the best way to layout page
Cleaning up unneeded styles more style refinements Style adjustments for small mobile
New function to determine if master user has been deleted/or is no longer a user on the site.
We are now tracking - My Jetpack views - requests to change primary user - successful primary user changes - request to disconnect site - confirmed disconnects - users who request support instead of confirming disconnect
Apply "current" class on tab if active
Consistent column naming and remove unecessary column headers
- No more button - No need for a custom table if no other admins
adjusted breakpoint to fit header better on small mobile devices.
dereksmart
force-pushed
the
add/my-jetpack-organized-commits
branch
from
2ff097b
to
e1d5d95
Compare
fixed color of footer clouds to match better on very tall screens
…' into add/my-jetpack-organized-commits
|
closing in favor of #2268 - this was has been gaffed by rebase |
dereksmart
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR does not include the dotcom changes that will be made on master user switch. That will be done in a following PR.
On this page, users will be able to view their connection information, as well as the ability to transfer "site ownership" aka master user.
You will need to run
gruntlocally to see the css file changes.Prior to testing, please disconnect jetpack entirely.
Begin testing:
Set up 3 separate user accounts; (at least) Two admins and one editor (or any non-admin). I found it's easiest to log in to all three accounts in different windows/browsers.
As the first admin:
As the second admin:
As the non-admin:
Repeat steps from the second admin. The Only difference should be that you can't do/see anything but link/unlink your own wpcom account to the site.
Some notes about My Jetpack