Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Jetpack: Simplify hook registration #23166

Conversation

leogermani
Copy link
Contributor

Fixes #

Changes proposed in this Pull Request:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/my-jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 1, 2022
@leogermani leogermani merged commit 94e02d3 into udpate/my-jetpack-filter-jetack-plugin-links Mar 1, 2022
@leogermani leogermani deleted the jetpack-links-leo-suggestion branch March 1, 2022 15:26
@github-actions github-actions bot removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 1, 2022
leogermani added a commit that referenced this pull request Mar 1, 2022
* [not verified] my-jetpack: extend actions link with My Jetpack

* [not verified] jetpack: do not add My Jetpack action link

* [not verified] changelog

* [not verified] changelog

* [not verified] my-jetpack: remove obsolte test

* my-jetpack: clean extending actions from initializer

* [not verified] my-jetpack: add methods to Product to handle action links

* [not verified] my-jetpack: extend action link

* [not verified] my-jetpack: define text domain for Search product

* my-jetpack: extend Jetpack plugin action links

* simplify hook registration (#23166)

* Skip tests in 5.6 and add comment

Co-authored-by: leogermani <leogermani@gmail.com>
Co-authored-by: Leo Germani <leogermani@automattic.com>
@oskosk oskosk changed the title simplify hook registration My Jetpack: Simplify hook registration Mar 14, 2022
@oskosk oskosk added this to In progress in My Jetpack 1.0 via automation Mar 14, 2022
@oskosk oskosk added this to the My Jetpack 1.0 milestone Mar 14, 2022
@renatoagds renatoagds moved this from In progress to Done in My Jetpack 1.0 Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants