Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Strip workspace refs from mirrors #23654

Merged
merged 3 commits into from
Mar 28, 2022
Merged

build: Strip workspace refs from mirrors #23654

merged 3 commits into from
Mar 28, 2022

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Mar 28, 2022

Changes proposed in this Pull Request:

They aren't going to be valid in the mirrors anyway, and when it comes
to JS packages they might confuse things. Best to strip them out,
leaving just the "public" version number.

Jetpack product discussion

none

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Compare the build artifact here with a build artifact from the parent ref.

@anomiex
Change style used for JS dependencies
9a33bf5 
It's annoying to have to update all the dependencies of monorepo JS
packages for every patch-level version bump. Let's make it work like the
PHP dependencies, where the dependencies are only updated on minor and
major bumps.

The new scheme looks like `workspace:* || ^1.2`. Within the monorepo the
`workspace:*` part is operative and the `^1.2` is ignored by pnpm but
will still be checked by CI.

When we publish we can strip the `workspace:* || ` bit leaving only the
`^1.2` for external users. But I'll save that change for a followup PR.
@anomiex
build: Strip workspace refs from mirrors
0d39868 
They aren't going to be valid in the mirrors anyway, and when it comes
to JS packages they might confuse things. Best to strip them out,
leaving just the "public" version number.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] Normal labels Mar 28, 2022
@anomiex anomiex self-assigned this Mar 28, 2022
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Mar 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2022 •
edited

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 29, 2022.

Backup plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 28, 2022.

Social plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 28, 2022.

Starter Plugin plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 28, 2022.

Protect plugin:

  • Next scheduled release: April 5, 2022.
  • Scheduled code freeze: March 28, 2022.

@sdixon194 sdixon194 added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 28, 2022
Base automatically changed from fix/js-dep-updates to master March 28, 2022 19:39
@anomiex anomiex requested a review from a team as a code owner March 28, 2022 19:39
@github-actions github-actions bot added [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin RNA labels Mar 28, 2022
@anomiex anomiex enabled auto-merge (squash) March 28, 2022 20:33
@anomiex anomiex merged commit 3ed4aa8 into master Mar 28, 2022
@anomiex anomiex deleted the add/mirror-build-strip-js-workspace-refs branch March 28, 2022 20:46
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdixon194 sdixon194 sdixon194 approved these changes

Assignees

@anomiex anomiex

Labels
[JS Package] API [JS Package] Components [JS Package] Connection [JS Package] IDC [JS Package] Licensing [JS Package] Partner Coupon [JS Package] Storybook [JS Package] Webpack Config [Package] Assets [Package] Connection UI [Package] Identity Crisis [Package] Jitm [Package] Lazy Images [Package] My Jetpack [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Pri] Normal RNA [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anomiex @sdixon194 @matticbot