-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement cosmetic changes to recommendations #26711
Implement cosmetic changes to recommendations #26711
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reload the page, and see that recommendation badge will appear without a necessity of going to "Recommendations" tab
Did it not do this before? I went and triggered a recommendation on my Ephemeral site and this is what I saw. Am I misunderstanding the change?
Other than this note, everything tests well and LGTM
It worked like this, but only for the "newRecommendations". Now, we need to fetch onboarding data which are stored as part of recommendations data, thus we needed to introduce additional query in other tabs. In the nutshell, all cosmetic changes introduced in this PR are related to new onboarding changes. |
@robertsreberski Ah I see, thank you for clarifying |
b85adef
into
add/post-purchase-recommendations-onboardings
This PR adds cosmetic improvements to the recommendations flow, especially after introducing post-purchase onboarding.
Fixes #
Changes proposed in this Pull Request:
Other information:
Jetpack product discussion
Related PR: #26484
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
<your_test_site>/wp-admin/admin.php?page=jetpack#/recommendations
, "Reset Options (dev only)" and reload the page.Supported plans: