Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jetpack Search readme #27341

Merged
merged 8 commits into from
Nov 13, 2022
Merged

Conversation

robfelty
Copy link
Contributor

@robfelty robfelty commented Nov 10, 2022

This updates the WordPress.org plugin readme to reflect the new pricing with the free tier.

Testing instructions:

Validated the readme with the wordpress.org validator - it passed.
I also previewed using wpreadme and it looks fine there too

Does this pull request change what data or activity we track or use?

No it does not.

@github-actions github-actions bot added the [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. label Nov 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Search plugin:

  • Next scheduled release: December 6, 2022.
  • Scheduled code freeze: November 28, 2022.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Nov 10, 2022
Copy link
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

projects/plugins/search/readme.txt Show resolved Hide resolved
@@ -16,9 +16,9 @@ Incredibly powerful and customizable, Jetpack Search helps your visitors instant

Jetpack Search is an easy-to-use WordPress search plugin that enhances the default site search functionality provided by the CMS. Thanks to advanced site search tools, your visitors will experience the best search experience you can offer.

From a predictive autocomplete algorithm, to instant search results, Jetpack Search has all the features and options for best site search usability and results.
From real-time search faceting , to instant search results, Jetpack Search has all the features and options for best site search usability and results.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "filtering and faceting".

I think "facets" are not a very well known term.


Note: A Jetpack Search subscription, or a Jetpack plan subscription that includes Search is required to use this plugin.
Jetpack Search is free to use for sites with up to 5000 documents and 500 search requests per month. Beyond that, we offer tiered pricing to fit the needs of your site.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"tiered pricing that grows with your site." ???

@@ -1,10 +1,10 @@
=== Jetpack Search ===
Contributors: automattic, annamcphee, bluefuton, kangzj, jsnmoon
Contributors: automattic, annamcphee, bluefuton, kangzj, jsnmoon, robfelty, gibrown
Tags: search, jetpack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "jetpack" and add some tags: "filter, woocommerce search, ajax search, product search"

@kangzj
Copy link
Contributor

kangzj commented Nov 10, 2022

I'll add these changes in 1.3.0 release, so feel free to close this one 😄

@robfelty
Copy link
Contributor Author

@kangzj @gibrown - it doesn't look like the readme changes made it into the 1.3.0 release - see https://wordpress.org/plugins/jetpack-search/

@kangzj
Copy link
Contributor

kangzj commented Nov 12, 2022

Hi @robfelty, I held the readme changes because the new pricing is not live yet. And as discussed in Slack, we are going to release another version of the Search plugin (probably 1.3.1) first thing next week, so let push forward with this PR 😄 Sorry for the confusion.

We might also want to change the plugin description in plugins/search/jetpack-search.php as noted by @gibrown .

Thanks for your work.

@kangzj kangzj added the [Feature] Search For all things related to Search label Nov 13, 2022
@kangzj kangzj changed the base branch from trunk to search/branch-1.3.0 November 13, 2022 21:06
@kangzj kangzj force-pushed the update/jetpack-search-readme branch from 320b9c8 to 17007b8 Compare November 13, 2022 21:14
@kangzj kangzj merged commit 294a297 into search/branch-1.3.0 Nov 13, 2022
@kangzj kangzj deleted the update/jetpack-search-readme branch November 13, 2022 21:27
@github-actions github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] Needs Team Review labels Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants