-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jetpack Search readme #27341
Update Jetpack Search readme #27341
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Search plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also update the author info in https://github.com/Automattic/jetpack/blob/trunk/projects/plugins/search/jetpack-search.php#L4
Similar to what Boost is doing: https://github.com/Automattic/jetpack/blob/a1e5f2edeaf82f5c7021ed39a8b39764ccbd61a4/projects/plugins/boost/jetpack-boost.php
(e.g. "Automattic - Jetpack Search team" )
projects/plugins/search/readme.txt
Outdated
@@ -16,9 +16,9 @@ Incredibly powerful and customizable, Jetpack Search helps your visitors instant | |||
|
|||
Jetpack Search is an easy-to-use WordPress search plugin that enhances the default site search functionality provided by the CMS. Thanks to advanced site search tools, your visitors will experience the best search experience you can offer. | |||
|
|||
From a predictive autocomplete algorithm, to instant search results, Jetpack Search has all the features and options for best site search usability and results. | |||
From real-time search faceting , to instant search results, Jetpack Search has all the features and options for best site search usability and results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "filtering and faceting".
I think "facets" are not a very well known term.
projects/plugins/search/readme.txt
Outdated
|
||
Note: A Jetpack Search subscription, or a Jetpack plan subscription that includes Search is required to use this plugin. | ||
Jetpack Search is free to use for sites with up to 5000 documents and 500 search requests per month. Beyond that, we offer tiered pricing to fit the needs of your site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"tiered pricing that grows with your site." ???
projects/plugins/search/readme.txt
Outdated
@@ -1,10 +1,10 @@ | |||
=== Jetpack Search === | |||
Contributors: automattic, annamcphee, bluefuton, kangzj, jsnmoon | |||
Contributors: automattic, annamcphee, bluefuton, kangzj, jsnmoon, robfelty, gibrown | |||
Tags: search, jetpack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "jetpack" and add some tags: "filter, woocommerce search, ajax search, product search"
I'll add these changes in 1.3.0 release, so feel free to close this one 😄 |
@kangzj @gibrown - it doesn't look like the readme changes made it into the 1.3.0 release - see https://wordpress.org/plugins/jetpack-search/ |
Hi @robfelty, I held the readme changes because the new pricing is not live yet. And as discussed in Slack, we are going to release another version of the Search plugin (probably 1.3.1) first thing next week, so let push forward with this PR 😄 Sorry for the confusion. We might also want to change the plugin description in Thanks for your work. |
320b9c8
to
17007b8
Compare
This updates the WordPress.org plugin readme to reflect the new pricing with the free tier.
Testing instructions:
Validated the readme with the wordpress.org validator - it passed.
I also previewed using wpreadme and it looks fine there too
Does this pull request change what data or activity we track or use?
No it does not.