-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect: Fix checks for paid plan #27355
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. 🔴 Action required: Please add missing changelog entries for the following projects: Use the Jetpack CLI tool to generate changelog entries by running the following command: Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Protect plugin:
|
0c8cb60
to
43569b7
Compare
…tpack's Jetpack_Plan class
…ect features and UI
38c21e2
to
22e488b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major improvement - awesome work!
Changes proposed in this Pull Request:
Scan::has_required_plan()
fromMy_Jetpack
due to server timeouts, this PR introduces a new way of validating the site plan using the connection package'sCurrent_Plan
. While the My Jetpack method validates the plan by availability of an accessible scan status, this alternate method directly checks the site's available features. This allows us to handle scenarios where the site has the correct plan, but no available scan status (i.e. right after purchase, the scanner may still be initializing and is "unavailable" for a few moments.)init
hook, moving any code that relies on status data to_admin_menu
, where it will be called only when necessary instead of every page load.Other information:
Jetpack product discussion
1201069996155224-as-1203341574761584
Does this pull request change what data or activity we track or use?
No
Testing instructions: