Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Sync jetpack_main_network_site option #27425

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Nov 15, 2022

Changes proposed in this Pull Request:

  • Adds jetpack_main_network_site to the Protect plugin's synced options.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?

Jetpack product discussion

peb6dq-dd-p2#comment-142

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Set up a JN site with only Protect running this branch
  • Connect Jetpack
  • Checkout the site's Jetpack debug results and verify the multisite message is not displayed.

@nateweller nateweller requested a review from a team November 15, 2022 18:45
@nateweller nateweller self-assigned this Nov 15, 2022
@nateweller nateweller added [Status] Needs Team Review [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. labels Nov 15, 2022
@nateweller nateweller marked this pull request as ready for review November 15, 2022 18:46
@github-actions
Copy link
Contributor

github-actions bot commented Nov 15, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Protect plugin:

  • Next scheduled release: December 6, 2022.
  • Scheduled code freeze: November 28, 2022.

@nateweller nateweller force-pushed the add/protect-sync-main-network-site branch from 5bb256b to 8451f7c Compare November 15, 2022 22:18
Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nateweller nateweller merged commit 3c4bd73 into add/scan-in-protect Nov 15, 2022
@nateweller nateweller deleted the add/protect-sync-main-network-site branch November 15, 2022 23:01
@nateweller nateweller mentioned this pull request Nov 16, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants