Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Add WAF header stat cards #27914

Closed

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Dec 13, 2022

Description

Adds StatCard components to the FirewallHeader

Changes proposed in this Pull Request:

  • Makes the StatCard component a default js-packages component export
  • Applies the StatCard component to the FirewallHeader
  • Retrieves and display WAF blocked requests when applicable

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • 1202232924268038-as-1203282049665710

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Checkout this branch
  • Start your Jurassic Tube without a scan level upgrade on a site with a history of blocked requests
  • Activate Protect and proceed to the Firewall tab
  • Ensure that the StatCard components are disabled, display the placeholder value, and a "Paid feature" label
  • Upgrade your plan
  • Return the Firewall page and verify that the StatCard components are now active and display an appropriate value for each period
  • Switch to mobile view and ensure that the structure and styling line up with the provided designs
  • Verify that there is no regression in app functionality introduced

Screenshots

Disabled:
Screen Shot 2022-12-20 at 14 28 28

Active:
Screen Shot 2022-12-20 at 14 22 19

Mobile:
Screen Shot 2022-12-20 at 14 28 07

Screen Shot 2022-12-20 at 14 22 37

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack add/protect-waf-stat-cards

to get started. More details: p9dueE-5Nn-p2

@github-actions github-actions bot added [JS Package] Components [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress RNA labels Dec 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2022

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/packages/waf, projects/plugins/protect

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Protect plugin:

  • Next scheduled release: March 7, 2023.
  • Scheduled code freeze: February 27, 2023.

@github-actions github-actions bot added [Package] WAF [Plugin] Boost A feature to speed up the site and improve performance. labels Dec 20, 2022
@dkmyta dkmyta changed the base branch from add/protect-waf-phase-2 to add/waf-stats-class December 20, 2022 18:51
@dkmyta dkmyta removed RNA [Plugin] Boost A feature to speed up the site and improve performance. labels Dec 20, 2022
@dkmyta dkmyta mentioned this pull request Dec 21, 2022
2 tasks
@github-actions github-actions bot added the RNA label Dec 21, 2022
@nateweller nateweller added this to the protect/1.2.2 milestone Jan 7, 2023
@dkmyta dkmyta changed the base branch from add/waf-stats-class to add/waf-stats-class-blocked-requests January 10, 2023 20:53
@nateweller nateweller removed this from the protect/1.4.0 milestone Jan 31, 2023
@github-actions github-actions bot deleted the branch add/waf-stats-class-blocked-requests August 15, 2023 00:49
@github-actions github-actions bot closed this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Components [Package] WAF [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA [Status] In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants