-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WAF: Extract definition of constants from Waf_Runner to Waf_Constants #28104
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
f8e128d
to
9eb64af
Compare
ed09fd2
to
ab5e17d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the changes, tests pass OK, and did a UI pass. LGTM!
Changes proposed in this Pull Request:
define_mode()
anddefine_share_data()
fromWaf_Runner
toWaf_Constants
.Waf_Constants::define_constants()
toWaf_Constants::define_bootstrap_constants()
, and extracts the three constants that it defines into three distinct methods:define_waf_directory()
,define_wpconfig_path()
, anddefine_killswitch()
.Other information:
Jetpack product discussion
peb6dq-mP-p2
Does this pull request change what data or activity we track or use?
No
Testing instructions: