-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writing prompts: move block to production and use for answering prompts #29433
Conversation
Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run
to get started. More details: p9dueE-5Nn-p2 |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
projects/plugins/jetpack/extensions/blocks/blogging-prompt/index.js
Outdated
Show resolved
Hide resolved
"blogging-prompts", | ||
"premium-content" | ||
], | ||
"experimental": [ "ai-image", "ai-paragraph", "anchor-fm", "blogging-prompt", "premium-content" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we consider making it a production block, so self-hosted sites can use it too? It seems like a useful block!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to that--I don't see why it can't be a production block assuming we can get the appropriate jetpack.com doc pages set up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's something Quill can help us with. I created 1200427382410585-as-1204188078771387/f to open a request with the team.
d70e99d
to
61ad8f3
Compare
I believe this PR is ready to go, but I want to get the remaining Writing Prompt block PRs merged before this one: |
01ff186
to
933eab1
Compare
Could just be config on my end, but I wasn't able to get the the header/footer to display correctly on my local dev site. Looked good on my test wpcom site though. When no explicit promptId is supplied, does it just grab an ID specified server side? |
That's probably caused by the changes from https://github.com/Automattic/jetpack/pull/29450/files not being available for whatever reason (not applied to sandbox, API not using sandbox, etc).
Correct, it gets the prompt specified for the day (we currently have a unique prompt for every day of the year). |
933eab1
to
6012a41
Compare
I rebased this to get the TeamCity build to pass--will need another approval. |
Proposed changes:
production
?answer_prompt={prompt_id}
query paramOther information:
Jetpack product discussion
PT: pe7F0s-uo-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
define( 'JETPACK_EXPERIMENTAL_BLOCKS', true );
)bin/jetpack-downloader test jetpack update/answer-prompt-w-block
(if not, the block header and footer will be empy, but is works, otherwise)/wp-admin/post-new.php?answer_prompt=1810
dailyprompt
anddailyprompt-{prompt_id}
should be added to the post_jetpack_blogging_prompt_key
should be added to the post, with the prompt id