[RNMobile] Fix inserting item from media library

[fluiddot]

Closes wordpress-mobile/gutenberg-mobile#5572.

⚠️ This PR depends on the following PRs:

• [RNMobile] Add metadata property to MediaInfo WordPress/gutenberg#48994
• [RNMobile] Add metadata property to MediaInfo wordpress-mobile/gutenberg-mobile#5558
• [Gutenberg] Add metadata parameter when inserting media into editor wordpress-mobile/WordPress-Android#18106
• [Gutenberg] Add metadata parameter when inserting media into editor wordpress-mobile/WordPress-iOS#20326

Proposed changes:

• When inserting an item from the media library, the VideoPress ID is passed via the metadata parameter of Media. Before this PR we were getting the value directly from the Media object.

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

NOTE: For testing this change it's required to use the changes from the PRs referenced above.

1. Open the app.
2. Go to a Simple site (videos uploaded in Simple sites are automatically added to VideoPress)
3. Go to the Media screen.
4. Upload a video.
5. Create/open a post.
6. Add VideoPress block.
7. Select "WordPress Media Library" option.
8. Select the uploaded video.
9. Observe that the placeholder is no longer displayed.
10. Preview the post.
11. Observe that the block is displayed and that the video can be played.

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

[github-actions]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack rnmobile/videopress-fix-insert-from-media-library

to get started. More details: p9dueE-5Nn-p2

[jhnstn]

Looks like ad65404 is the first new commit in the PR.

That change looks good to me. I can re-approve once the branch is synced back up with trunk.

[fluiddot]

Looks like ad65404 is the first new commit in the PR.

@jhnstn Good catch. Yeah, that commit is the actual change of this PR. I've rebased this branch with trunk so now the PR should only show that change.

That change looks good to me. I can re-approve once the branch is synced back up with trunk.

I'm afraid you'd need to re-approve it because your previous review will be dismissed. Thanks!

[nunyvega]

LGTM!