Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcodes: Medium: Improve URL path type matching #3063

Merged
merged 1 commit into from Dec 28, 2015

Conversation

aduth
Copy link
Contributor

@aduth aduth commented Nov 24, 2015

Currently, user stories are interpreted as profiles, as they begin with an "@"-prefixed path. The patterns introduced in this pull request improve matching against profiles and collections, including more accurate supported characters.

Example URLs to test against:

Supported characters are not widely published, but were inferred as follows:

  • For user names, numbers, letters, dots, and underscores are permitted. You can verify this by attempting to change your username from the Medium settings page to include any character not in this set, and observe the error message.
  • For collections/publications, supported characters were inferred by attempting to include a variety of special characters and letters in the Medium New Publication form. After creating the Publication, all non-letters/numbers are converted to dashes.

@aduth aduth added [Feature] Shortcodes / Embeds [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 24, 2015
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Nov 25, 2015
@jeherve jeherve added this to the 3.9 milestone Nov 25, 2015
@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Dec 24, 2015
@zinigor
Copy link
Member

zinigor commented Dec 24, 2015

Looks good, works as expected, thank you!

samhotchkiss added a commit that referenced this pull request Dec 28, 2015
Shortcodes: Medium: Improve URL path type matching
@samhotchkiss samhotchkiss merged commit d46de9e into master Dec 28, 2015
@samhotchkiss samhotchkiss deleted the fix/medium-path-matching branch December 28, 2015 19:56
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Dec 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes / Embeds [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants