-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: use the Jetpack Plans package in the Jetpack plugin, and deprecate existing class #31213
Conversation
Use the Connection package instead, we know it will be available with the Plans package.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
…tpack-plan-current-plan
…tpack-plan-current-plan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, diffing trunk projects/plugins/jetpack/class.jetpack-plan.php
and projects/packages/plans/src/class-current-plan.php
shows minimal differences and some quick poking around with this on wpcom didn't blow up.
Not sure what's going on with all the failing E2E tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glad I decided to poke at the E2E failures, found a bug.
Also this needs a version bump now.
Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
Fixes #31213
Proposed changes:
In this PR, we start using the package in the Jetpack plugin, and deprecate the existing class. No features should be impacted by the change, everything should work just like before.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Lots of things to test here. I would also recommend tailing the site's logs as you test, to ensure no calls of
Jetpack_Plan
(now returning deprecation notices) remains.