Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Change MariaDB version to LTS #31315

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

TimBroddin
Copy link
Contributor

@TimBroddin TimBroddin commented Jun 12, 2023

Proposed changes:

I ran into an issue where running jetpack docker up failed to start MariaDB, because the mysqld binary was not available in the container image.

It seems like MariaDB decided to sunset the mysql/mysqld commands in favor of mariadbd/mariadb commands, but didn't update the Docker image to reflect this.

This PR updates the version used from latest to lts.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1686562119649609-slack-C0299DMPG

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  1. Checkout this branch
  2. Run jetpack docker up

@TimBroddin TimBroddin self-assigned this Jun 12, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • 🔴 Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jun 12, 2023
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jun 12, 2023
@jeherve jeherve merged commit 3a3419b into trunk Jun 12, 2023
51 checks passed
@jeherve jeherve deleted the fix/docker-mariadb-version branch June 12, 2023 11:39
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 12, 2023
pablinos added a commit that referenced this pull request Jun 12, 2023
Similar to #31315 we need to change the version in the post-build action
to stop the 'Test plugin upgrades' check from failing.
pablinos added a commit that referenced this pull request Jun 12, 2023
* [not verified] Tock Block: Add a block for a Tock widget

This is an initial version of a Tock block based on the [Tock
Widget](https://wordpress.org/plugins/tock-widget/) plugin.

* [not verified] Update the styling to handle alignment

* [not verified] Swap to using a popover for the URL input

* [not verified] Add submit button

* [not verified] add translatable string

* Following #31315, update the MariaDB version is the post-build action

* Fix the example viewport width.

* Fix Sandbox refresh in Chrome

* Update the notice text.

* Change key event to down, so the popover can be triggered by enter.

---------

Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants