Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Logos: update to include a Fediverse and a Nextdoor logo. #31404

Merged
merged 8 commits into from Jun 19, 2023

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jun 15, 2023

Fixes #14280

Proposed changes:

This PR updates our social logos icon font and introduces new logos for our Social Icons widget and Social Menu theme tool, matching the Social Logos update, 2.5.3:

It also introduces a new filter, that was asked in #14280 and that will make testing this PR easier.

Related:

Note
This doesn't introduce any frontend elements by default for the Fediverse logo yet, since there isn't a single domain name we can use to point to a Fediverse site.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Go to yoursite.com/wp-content/plugins/jetpack/_inc/social-logos/social-logos.html
  • Check the new logos
  • Go to Jetpack > Settings and enable Sharing buttons as well as the extra sidebar widgets.
  • Switch to an old theme, like Twenty Ten.
  • Go to Plugins > Add New and install the Classic Widgets plugin.
  • In a functionality plugin, add the following:
// Add social menu support
add_action( 'after_setup_theme', function () {
	add_theme_support( 'jetpack-social-menu', 'svg' );
} );
add_filter(
	'jetpack_social_icons_supported_icons',
	function ( $social_links_icons ) {
		$social_links_icons[] = array(
			'url'   => array( 'fedi.jeremy.hu' ),
			'icon'  => 'fediverse',
			'label' => 'Fediverse',
		);
		return $social_links_icons;
	}
);
  • Edit your theme and add the following, in footer.php for example
<?php jetpack_social_menu(); ?>
  • Go to Appearance > Customize > Menus
  • Create a new menu with some links, e.g. https://www.facebook.com/jetpackme and https://nextdoor.com/city/agua-dulce--ca/
  • Assign that menu to the Social Menu location
  • Go to Appearance > Widgets menu
  • Drag the Social Icons widget to one of the active widget areas, and add some links again. Add a custom URL using this URL too: https://fedi.jeremy.hu/@jeremy
  • Check how things look like on the frontend, for both your social menu and the Social Icons Widget you created.

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons [Feature] Theme Tools [Status] In Progress [Pri] Normal labels Jun 15, 2023
@jeherve jeherve self-assigned this Jun 15, 2023
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jun 15, 2023
@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Jetpack plugin:

  • Next scheduled release: July 5, 2023.
  • Scheduled code freeze: June 26, 2023.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 15, 2023

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack plugin. Once the plugin is active, go to Jetpack > Jetpack Beta > Jetpack and enable the update/social-logos-icon-font-fediverse-nextdoor branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack update/social-logos-icon-font-fediverse-nextdoor
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-logos-icon-font-fediverse-nextdoor
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Jun 16, 2023
Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work. Too bad #28861 hasn't happened yet.

@jeherve jeherve merged commit 4ff98f4 into trunk Jun 19, 2023
60 of 61 checks passed
@jeherve jeherve deleted the update/social-logos-icon-font-fediverse-nextdoor branch June 19, 2023 13:32
@github-actions github-actions bot added this to the jetpack/12.3 milestone Jun 19, 2023
@github-actions github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Jun 19, 2023
kangzj pushed a commit that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Extra Sidebar Widgets [Feature] Sharing Post sharing, sharing buttons [Feature] Theme Tools [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Icons: add hooks like previous file social-media-icons.php
2 participants