-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor registration of experimental blocks #33073
Refactor registration of experimental blocks #33073
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
17e4be3
to
defa226
Compare
defa226
to
6bc7f3f
Compare
* [not verified] Refactor registration of experimental blocks * [not verified] Use get_block_feature to print class name * [not verified] Add changelog
See #32602
Proposed changes:
Registers the experimental blocks (AI Image, AI Paragraph) by specifying the path to their block.json file. This was made possible by #32697. The goal is to avoid the duplication of block metadata and use block.json as the source of truth.
In more details, for each block (when needed):
editorScript
property fromblock.json
(automatically added during the build)icon
property ofblock.json
icon.js
shared-extension-utils
packageblock.json
index.js
toblock.json
andeditor.js
and delete the fileattributes.js
toblock.json
and delete the fileOther information:
Jetpack product discussion
pedMtX-RS-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Experimental blocks are not shown in the block inserter. Below, I explain how to display them in your local test site so that they can be tested. There may be easier ways but I'm not aware of them.
define( 'JETPACK_BLOCKS_VARIATION', 'experimental' );
to/projects/jetpack/tools/docker/wordpress/wp-config.php
.supports.inserter
property inblock.json
for for the AI Paragraph and AI Image blocks.register_block
inai-image.php
andai-paragraph.php
project/plugins/jetpack
:pnpm build-extensions