-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix block view scripts being loaded twice #33406
Fix block view scripts being loaded twice #33406
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
474d88e
to
08b2964
Compare
Thank you for working on this one @monsieur-z, I have pulled this branch and tested the blogroll blog and I confirm that I could not reproduce the issue anymore and our view.js file is being loaded only once! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes p1695989732543079/1694788078.746839-slack-CDLH4C1UZ
Proposed changes:
The block registration method introduced in #33326 made possible the loading of assets defined in a
block.json
file. However, block assets are still enqueued explicitly in the backend at the moment. This caused assets to be loaded twice. This PR fixes by removing assets definition fromblock.json
files for the moment.Other information:
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Posts > Add New
.wp-content/plugins/jetpack/_inc/blocks/blogroll/view.js
is loaded only once.