Add/user col user connected #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we'll need this later, and it can't be in a private Class.
This adds a blank column to the user admin table that will show a green Jetpack icon is the user is linked to a WordPress.com account
dereksmart
added
[Type] Enhancement
| fill: #8cc258; | ||
| } | ||
| </style> | ||
| <? } |
This may help other users wanting to link their own account.
|
I made a couple more changes, including a link to "My Jetpack". Would it be worth adding an emblem for the current user as well, but keep it grayed out if you're not connected to WordPress.com, with the same link to "My Jetpack"? It might be a good incentive for folks to link their own account as well. |
|
@jeherve good suggestions! How about we keep this branch as "base" functionality for now until 4.0 is further developed and we can implement more fanciness when we know how it will tie in better? |
"My Jetpack" will disappear in Jetpack 4.0. Let's avoid linking to it from now on. @see #3433 (comment)
|
This looks good to merge. 👍 |
jeherve
added
[Status] Ready to Merge
jeherve
removed
the
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Jun 21, 2016
"My Jetpack" will disappear in Jetpack 4.0. Let's avoid linking to it from now on. @see #3433 (comment)
jeherve
added a commit
that referenced
this pull request
Jun 21, 2016
jeherve
added a commit
that referenced
this pull request
Jun 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a blank column to the user admin table that will show a green Jetpack icon is the user is linked to a WordPress.com account.
This PR is intended to provide a very simple functionality. Show a logo if user is linked. Tooltip on hover reads an explanation, currently:
This user is linked and ready to fly with Jetpack.. Let's look at adding more functionality to this once the base 4.0 is merged in and we know how it'll tie in better with user connection stuff.addresses #2601