Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM: Resolves 3390 - bypass errant codeception dependency #34425

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

tbradsha
Copy link
Contributor

@tbradsha tbradsha commented Dec 1, 2023

Resolves Automattic/zero-bs-crm#3390 - bypass errant codeception dependency

Proposed changes:

This updates composer.json to avoid v3.1.1 of codeception/module-db.

External dependency bug report: Codeception/module-db#64

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Switch to PHP 8.0
  2. Update composer dependencies: composer update
  3. Run tests: composer tests

In trunk, one gets this error:

[TypeError] Codeception\Lib\Driver\Db::isBinary(): Argument #1 ($string) must be of type string, float given, called in /vendor/codeception/module-db/src/Codeception/Lib/Driver/Db.php on line 297  

In the fix/crm/3390-bypass_errant-dependency branch, the tests complete successfully.

@tbradsha tbradsha added this to the crm/6.3.1 milestone Dec 1, 2023
@tbradsha tbradsha requested a review from anomiex December 1, 2023 17:02
@tbradsha tbradsha self-assigned this Dec 1, 2023
@tbradsha tbradsha added [Status] Needs Team Review [Plugin] CRM Issues about the Jetpack CRM plugin labels Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

@tbradsha tbradsha requested a review from a team December 1, 2023 17:48
@tbradsha tbradsha merged commit 26f3e40 into trunk Dec 1, 2023
49 checks passed
@tbradsha tbradsha deleted the fix/crm/3390-bypass_errant-dependency branch December 1, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] CRM Issues about the Jetpack CRM plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants