-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WooCommerce Analytics: check if product exists before we use it #35566
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
@@ -68,7 +68,13 @@ protected function format_items_to_json( $items ) { | |||
} else { | |||
$product = $item['data']; | |||
} | |||
|
|||
if ( ! $product || ! $product instanceof WC_Product ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the last condition, ! $product instanceof WC_Product
, should be sufficient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works as expected. Thanks, @jeherve!
Fixes #35562
Proposed changes:
Account for all possible returns from
wc_get_product
when checking for the different items present in a cart. It should avoid issues like the one reported in #35562.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
/checkout/order-received/<order-id>/
—this firescapture_order_confirmation_view
jetpack/projects/plugins/jetpack/modules/woocommerce-analytics/classes/class-jetpack-woocommerce-analytics-checkout-flow.php
Lines 35 to 37 in e49db6b
/checkout/order-received/<order-id>/